Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format 'new expression' consistently as non-code #399

Closed
wants to merge 1 commit into from

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 11, 2014

zygoloid: "It's semantic rather than syntactic, so no \tcode."

@pah
Copy link

pah commented Nov 11, 2014

Hmm, but now it reads as "new expression", as if in contrast to some "old expression". To me, this looks confusing compared to "new expression" with proper \tcode highlighting of the keyword.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 11, 2014

That's true. We use plain-text "new expression" a couple of times, though. Maybe they should all be \grammarterm{new-expression}?

@pah
Copy link

pah commented Nov 11, 2014

Maybe they should all be \grammarterm{new-expression}?

Sounds like a better resolution to me. 👍

@zygoloid
Copy link
Member

zygoloid: "It's semantic rather than syntactic, so no \tcode."

This was referring to the phrase "placement new", not to the phrase "new expression". But I note that we don't ever define what a "placement new" actually is; we should add such a definition to [expr.new]p13 (...; such an expression is called a \defn{placement \grammarterm{new-expression}}.), and then consistently format uses of the term the same way we format the definition.

"new expression" should either be \tcode{new} expression or \grammarterm{new-expression}; the latter seems more precise, and I'd prefer that.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 11, 2014

I'm retracting this PR.

@tkoeppe tkoeppe closed this Nov 11, 2014
@tkoeppe tkoeppe deleted the newexpr branch November 11, 2014 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants