Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[concept.swappable] Missing an index entry for ranges::swap #4003

Closed
AlisdairM opened this issue May 19, 2020 · 3 comments · Fixed by #4008
Closed

[concept.swappable] Missing an index entry for ranges::swap #4003

AlisdairM opened this issue May 19, 2020 · 3 comments · Fixed by #4008
Assignees
@jensmaurer

Comments

@AlisdairM
Copy link
Contributor

AlisdairM commented May 19, 2020 •
edited by jwakely

The ranges::swap CPO is in the <concepts> header, quite removed from the original swap function in the <utility> header. It should have its own index entry so that it is easy to find.
@jensmaurer
Copy link
Member

@AlisdairM , do you have any specific index entry formatting in mind? We already have a cross-reference to ranges::swap under the name "swap".

@jensmaurer jensmaurer self-assigned this May 22, 2020
@jensmaurer jensmaurer mentioned this issue May 22, 2020
Merged
@jensmaurer jensmaurer linked a pull request May 22, 2020 that will close this issue
Fix index entries for CPOs #4008
Merged
@AlisdairM
Copy link
Contributor Author

An index entry under 'swap' for ranges::swap is exactly what I was thinking of, but I do not see it in the index - I just triple checked on my current build from 'master'. Nor do I see it added in the linked PR #4008. Maybe I mis-understood where to look for the existing reference?

@jwakely
Copy link
Member

jwakely commented May 23, 2020

In the index of library names, the first entry for swap which goes to page 540, where [concept.swappable] defines ranges::swap in p2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix index entries for CPOs jensmaurer/draft
3 participants
@AlisdairM @jwakely @jensmaurer