Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[std] Harmonize phrasing 'terminate is invoked' #4005

Merged
merged 1 commit into from Oct 29, 2020

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented May 21, 2020

instead of saying 'is called'.
Also add cross-references to [except.terminate].
Also use 'exits via an exception' consistently.

Fixes #3079.

@jensmaurer jensmaurer requested a review from jwakely May 21, 2020 22:59
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@jensmaurer
Copy link
Member Author

@tkoeppe, could you review this, please? If you agree, I would apply without consulting @zygoloid .

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 1, 2020

Agreed, this looks very nice -- esp. the cleanup around the exit handlers looks like an improvement. Ship it!

@tkoeppe tkoeppe self-requested a review June 1, 2020 10:29
@zygoloid zygoloid added this to the C++23 milestone Sep 18, 2020
@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 6, 2020
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 21, 2020
instead of saying 'is called'.
Also add cross-references to [except.terminate].
Also use 'exits via an exception' consistently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"terminate is called" inconsistency
4 participants