Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class, utility] Clarify 'cv-void class members' and make spelling more consistent #402

Merged
merged 2 commits into from Nov 19, 2015

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 13, 2014

No description provided.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 13, 2014

See Issue #392.

@@ -1072,7 +1072,7 @@
\indextext{definition!static member}%
The declaration of a \tcode{static} data member in its class definition
is not a definition and may be of an incomplete type other than
cv-qualified \tcode{void}. The definition for a \tcode{static} data
\cvqual{cv} \tcode{void}. The definition for a \tcode{static} data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use \cv\ \tcode{void}

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 14, 2014

Hm, that's just a shorthand for the same thing and we use \cvqual{cv} in several other places. Should we have a separate cleanup? We also variably use \cv\ \tcode{foo} and \tcode{\cv{} foo}.

I'd prefer general guidance on which one to use and how, put that on the wiki, then clean everything up in one wash. What do you think?

@zygoloid
Copy link
Member

Sounds like a good idea to me.

On Fri, Nov 14, 2014 at 4:01 AM, Thomas Köppe notifications@github.com
wrote:

Hm, that's just a shorthand for the same thing and we use \cvqual{cv} in
several other places. Should we have a separate cleanup? We also variably
use \cv\ \tcode{foo} and \tcode{\cv{} foo}.

I'd prefer general guidance on which one to use and how, put that on the
wiki, then clean everything up in one wash. What do you think?


Reply to this email directly or view it on GitHub
#402 (comment).

@tkoeppe tkoeppe force-pushed the cvvoid branch 3 times, most recently from e7991f1 to 351182e Compare November 14, 2015 04:02
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 14, 2015

Changed it to \cv\ \tcode{void} and also made the only two uses of \tcode{\cv consistent. Now we have only two style ambiguities left:

1 \cv\ vs \cv{}
2. \cv vs \cvqual{cv}

I'm happy to leave both of those be, since in both cases each alternative has roughly the same amount of use.

PTAL

@tkoeppe tkoeppe changed the title [class] Clarify 'cv-void class members' [class, utility] Clarify 'cv-void class members' and make spelling more consistent Nov 18, 2015
zygoloid added a commit that referenced this pull request Nov 19, 2015
[class, utility] Clarify 'cv-void class members' and make spelling more consistent
@zygoloid zygoloid merged commit 1d3fe3c into cplusplus:master Nov 19, 2015
@tkoeppe tkoeppe deleted the cvvoid branch November 19, 2015 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants