Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[util.smartptr.weak] Remove declarations already in [memory.syn] #4037

Merged
merged 1 commit into from Dec 14, 2020
Merged

[util.smartptr.weak] Remove declarations already in [memory.syn] #4037

merged 1 commit into from Dec 14, 2020

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Jun 11, 2020 •
edited

Partially addresses #4041.

@jensmaurer
Copy link
Member

@jwakely , can you confirm?

@jensmaurer
Copy link
Member

@jwakely , ping?

jwakely
jwakely reviewed Aug 29, 2020
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be consistent, but I'm not sure it's actually an improvement. The declaration of swap in [memory.syn] is very far away. This declaration puts [util.smartptr.weak.spec] in context.

@jwakely
Copy link
Member

jwakely commented Aug 29, 2020

I won't object if the editor (or editorial team) wants to do this though.

@zygoloid zygoloid added the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 18, 2020
@jensmaurer jensmaurer mentioned this pull request Sep 19, 2020
Closed
@jensmaurer jensmaurer added after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. and removed decision-required A decision of the editorial group (or the Project Editor) is required. labels Dec 4, 2020
@jensmaurer jensmaurer added this to the post-2020-11 milestone Dec 4, 2020
@jensmaurer
Copy link
Member

Editorial meeting: Remove redundancy = apply.

@JohelEGP JohelEGP mentioned this pull request Dec 4, 2020
Closed
@tkoeppe tkoeppe merged commit e0b3fe1 into cplusplus:master Dec 14, 2020
@JohelEGP JohelEGP deleted the util.smartptr.weak branch January 30, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied.
Projects
None yet
Milestone
post-2020-11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohelEGP @jensmaurer @jwakely @zygoloid @tkoeppe