Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[string.view.template] Deduction guide specified far from constructors #4039

Closed
JohelEGP opened this issue Jun 11, 2020 · 3 comments · Fixed by #5397
Closed

[string.view.template] Deduction guide specified far from constructors #4039

JohelEGP opened this issue Jun 11, 2020 · 3 comments · Fixed by #5397
Assignees
@jensmaurer

Comments

@JohelEGP
Copy link
Contributor

array's is specified right after the constructors, in the same subclause.
span's are specified on their own subclause after the special member functions'.
string_view's are right before the non-member functions. There's a lot of material between its special member function specifications and the non-members'.
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jun 11, 2020
@jensmaurer
Copy link
Member

We often have a subclause "member functions", but deduction guides are not one of these, so they don't really fit there. On the other hand, they should really go next to the constructors, semantically.

@JohelEGP
Copy link
Contributor Author

Based on #5385 (comment), do you agree with this issue, @jwakely?

@jwakely
Copy link
Member

jwakely commented Apr 17, 2022

That comment was about where we declare the deduction guides, and string view's are consistent: they're declared with the class synopsis.

I wasn't expressing an opinion about where we put the detailed specifications. But I wouldn't object to moving [string.view.deduct] immediately after [string.view.cons]. That makes sense from the "telling you how you can initialise the type" perspective.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Apr 17, 2022
@jensmaurer jensmaurer self-assigned this Apr 17, 2022
@jensmaurer jensmaurer mentioned this issue Apr 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[string.view.deduct] Move to immediately after [string.view.cons] jensmaurer/draft
3 participants
@jwakely @JohelEGP @jensmaurer