Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lib] Non-member swap inconsistently specified in class synopsis #4041

Closed
JohelEGP opened this issue Jun 11, 2020 · 2 comments · Fixed by #4448
Closed

[lib] Non-member swap inconsistently specified in class synopsis #4041

JohelEGP opened this issue Jun 11, 2020 · 2 comments · Fixed by #4448

Comments

@JohelEGP
Copy link
Contributor

In header synopsis only In class synopsis
pair, tuple, optional, variant, any
{unique,shared}_ptr weak_ptr
function
array, stack deque, forward_list, list, vector-not-of-bool, (multi){map,set}, unordered_(multi){map,set}, (priority_)queue
valarray
basic_{stringbuf,(i,o)stringstream,filebuf,(i,o)fstream,syncbuf} (only)
fs::path
basic_regex, match_results
thread
{unique,shared}_lock
promise, packaged_task

The remaining are friends or depend on the generic std::swap via ADL.
This was referenced Jun 11, 2020
Closed
Merged
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 8, 2020
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Dec 4, 2020

Considering #4037 (comment) and #4035 (comment), does this still need the decision-required tag?

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Dec 5, 2020
@jensmaurer
Copy link
Member

Summary of editorial meeting consensus documented in #4035 and #4037: non-member swap should be in the header synopsis, not in the class synopsis.

@JohelEGP JohelEGP mentioned this issue Dec 6, 2020
Merged
@jensmaurer jensmaurer mentioned this issue Jan 3, 2021
Merged
@JohelEGP JohelEGP mentioned this issue Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lib] Ensure non-member swap is declared in the header synopsis only jensmaurer/draft
2 participants
@JohelEGP @jensmaurer