Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[special.mem.concepts] Append -for to no-throw-sentinel #4050

Closed
JohelEGP opened this issue Jun 20, 2020 · 5 comments · Fixed by #4100
Closed

[special.mem.concepts] Append -for to no-throw-sentinel #4050

JohelEGP opened this issue Jun 20, 2020 · 5 comments · Fixed by #4100

Comments

@JohelEGP
Copy link
Contributor

I can't find proof to thinking that maybe it was decided not to rename this one.

@jensmaurer
Copy link
Member

This is an exposition-only name, so we could editorially rename this, but I'd like to have buy-in from LWG before doing so.
@jwakely and @CaseyCarter , what's your viewpoint?

@CaseyCarter
Copy link
Contributor

I can't find proof to thinking that maybe it was decided not to rename this one.

P1754 largely ignored exposition-only concepts since it wasn't crucial to get their naming correct for C++20. I agree that no-throw-sentinel-for is an improvement in consistency with the normative concept names.

@jwakely
Copy link
Member

jwakely commented Jun 21, 2020

Works for me. We could also drop the hyphen in no-throw for consistency with numerous type traits.

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Jun 21, 2020

Works for me. We could also drop the hyphen in no-throw for consistency with numerous type traits.

If you can convince the editor that "nothrow" is one word instead of two, I won't stand in your way ;) (Serious response: I'm fine with this suggestion as well - it's better to be consistently wrong than inconsistently sometimes right.)

@JohelEGP
Copy link
Contributor Author

Opened #4101 for the no-throw renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants