Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iterator.cpp17] Index old-style iterator requirements. #4060

Merged
merged 1 commit into from Sep 18, 2020

Conversation

jensmaurer
Copy link
Member

Fixes #3835

@zygoloid zygoloid added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Sep 18, 2020
@@ -1885,7 +1885,7 @@
\ref{bidirectional.iterators}, \ref{random.access.iterators}).

\pnum
A type \tcode{X} meets the \oldconcept{Iterator} requirements if:
A type \tcode{X} meets the \defnoldconcept{Iterator} requirements if:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems surprising to have two defnoldconcepts for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Sep 18, 2020
@jensmaurer
Copy link
Member Author

Rebased, fixed, and force-pushed.

@zygoloid zygoloid added the index label Sep 18, 2020
@zygoloid zygoloid merged commit 3562275 into cplusplus:master Sep 18, 2020
@jensmaurer jensmaurer deleted the c29 branch September 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iterator.cpp17] The iterator "old" concepts (Cpp17Requirements) are not indexed
2 participants