[stmt.pre, re.grammar, gram] Use a separate bnf environment for each nonterminal. #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eelis
changed the title
|
Ideally, we would script-check this in the future, to avoid introducing regressions. |
jensmaurer
approved these changes
Jul 5, 2020
|
@tkoeppe , could you have a look, please? This seems an easy one. |
|
Looks good, thanks! I agree that if we never want to have multiple definitions per environment, we could have a more structured environment -- that would probably also obviate the need for a presubmi check (assuming we could get rid of the permissive existing environment that allows multiple definitions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already done everywhere else in the document as far as I can tell.
No visible difference in the PDF.
(Incidentally, this change makes life easier for cxxdraft-htmlgen.)