Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fs.class.path, fs.path.nonmember] Fix inline whitespace #4092

Merged
merged 1 commit into from Sep 3, 2020
Merged

[fs.class.path, fs.path.nonmember] Fix inline whitespace #4092

merged 1 commit into from Sep 3, 2020

Conversation

JohelEGP
Copy link
Contributor

No description provided.

@jwakely
Copy link
Member

jwakely commented Jul 25, 2020 •
edited

That whitespace is used to align the names with earlier ones, so was intentional. This use of whitespace to align names in class synopses is not our usual convention. But if you're going to remove it here, why not also do it above where void clear() noexcept; and void swap(path& rhs) noexcept; are aligned with the declarations between them? And also for string, wstring, u8string etc. and generic_string, generic_wstring, generic_u8string?

I think either we should remove all that whitespace used for alignment, or none of it.

JohelEGP
JohelEGP commented Jul 25, 2020
View reviewed changes
source/iostreams.tex Outdated
const value_type* c_str() const noexcept;
const value_type* c_str() const noexcept;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that this was actually aligned. The parentheses are what stood out to me, not the name. I will keep only the other change, whose alignment became outdated with the addition of operator<=>.

@JohelEGP JohelEGP force-pushed the fs.class.path branch 2 times, most recently from bf40573 to cfd8387 Compare July 25, 2020 22:32
@JohelEGP JohelEGP changed the title [fs.class.path] Fix inline whitespace [fs.class.path, fs.path.nonmember] Fix inline whitespace Jul 25, 2020
jwakely
jwakely approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jensmaurer jensmaurer merged commit eb367f6 into cplusplus:master Sep 3, 2020
@JohelEGP JohelEGP deleted the fs.class.path branch September 3, 2020 21:33
zygoloid pushed a commit to zygoloid/cplusplus that referenced this pull request Sep 22, 2020
@JohelEGP @zygoloid
[fs.class.path, fs.path.nonmember] Fix inline whitespace (cplusplus#4092
5511ba7 
)
zygoloid pushed a commit to zygoloid/cplusplus that referenced this pull request Sep 22, 2020
@JohelEGP @zygoloid
[fs.class.path, fs.path.nonmember] Fix inline whitespace (cplusplus#4092
bbb0118 
)
zygoloid pushed a commit that referenced this pull request Sep 22, 2020
@JohelEGP @zygoloid
[fs.class.path, fs.path.nonmember] Fix inline whitespace (#4092)
c855117
tkoeppe pushed a commit that referenced this pull request Sep 22, 2020
@JohelEGP @tkoeppe
[fs.class.path, fs.path.nonmember] Fix inline whitespace (#4092)
c23aaa2
tkoeppe pushed a commit that referenced this pull request Sep 24, 2020
@JohelEGP @tkoeppe
[fs.class.path, fs.path.nonmember] Fix inline whitespace (#4092)
a424ceb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohelEGP @jwakely @jensmaurer