Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[special.mem.concepts] Remove hyphen in _no-throw_ for consistency with the type traits #4101

Closed
JohelEGP opened this issue Jul 31, 2020 · 6 comments · Fixed by #4942
Closed
Assignees

Comments

@JohelEGP
Copy link
Contributor

See #4050 (comment).

@jensmaurer
Copy link
Member

While our type traits are named is_nothrow_something, we also have NoThrowForwardIterator (note capital F, indicate a new word).

If we fix this, we should remove the hyphen from "no-throw" (names of exposition-only concepts) and we should rename NoThrowForwardIterator to NothrowForwardIterator for consistency.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 8, 2020
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 24, 2021

@jwakely: Thoughts? We're inclined to drop the hyphen and say "nothrow" everywhere.

@tkoeppe tkoeppe removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 24, 2021
@jwakely
Copy link
Member

jwakely commented Sep 24, 2021

I think making nothrow-sentinel-for consistent with nothrow_constructible makes sense. I'm less convinced that NothrowFoo is an improvement on NoThrowFoo.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 24, 2021

Right, I'd also be happy with keeping the camel-case "NoThrow", that seems inoffensive enough. @jensmaurer: could you live with "nothrow-foo" and "NoThrowFoo"?

@jensmaurer
Copy link
Member

I'm ok with that; it's an incremental improvement which we can iterate on in the future should the pain about NoThrowFoo grow.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2021

Great, let's do that then: snake-case nothrow_foo without hypen, and camel-case can use NoThrowFoo is desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants