Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lib] Fix typos in "The expression in...is equivalent to" #4108

Merged
merged 1 commit into from Sep 3, 2020
Merged

[lib] Fix typos in "The expression in...is equivalent to" #4108

merged 1 commit into from Sep 3, 2020

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Aug 2, 2020

No description provided.

@jensmaurer
Copy link
Member

This looks harmless and the right thing to do. @jwakely , could you please have a quick look?

jwakely
jwakely approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had a better way to say "inside explicit" or "inside noexcept", but given our current wording style, this is a clear improvement. Thanks.

@jensmaurer jensmaurer merged commit 8825604 into cplusplus:master Sep 3, 2020
@JohelEGP JohelEGP deleted the expr-in-x-equivalent-to-typos branch September 3, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohelEGP @jensmaurer @jwakely