Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thread.condvarany.intwait] contains reference to nonexistent "cv" variable #4114

Closed
BillyONeal opened this issue Aug 18, 2020 · 0 comments · Fixed by #4115
Closed

[thread.condvarany.intwait] contains reference to nonexistent "cv" variable #4114

BillyONeal opened this issue Aug 18, 2020 · 0 comments · Fixed by #4115

Comments

@BillyONeal
Copy link
Contributor

[thread.condvarany.intwait]/7 has the following (comment is mine)

while (!stoken.stop_requested()) {
    if (pred())
        return true;
    if (cv.wait_until(lock, abs_time) == cv_status::timeout) // this cv. shouldn't be here
        return pred();
}
return pred();

Presumably this was copied from a reference implementation that built the new waits using another internal condition_variable, where "cv" was the condition_variable member.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[thread.condvarany.intwait] remove reference to nonexistent "cv" variable
1 participant
@BillyONeal