Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class.virtual] index semantics of final and override #4139

Merged

Conversation

AlisdairM
Copy link
Contributor

Index the two paragraphs that actually specify the rules for 'final'
and 'override' virt-specifiers applied to functions.

I chose to index these specifiers using the 'keyword' macro rather
than try to set up a separate indextext entry to ensure:

  1. the index points to the right page if ever the paragraph splits
    across pages
  2. the form is consistent with every othert index entry for these
    two contextual keywords, which are all created by 'keyword'
    Visually confirmed that the text renders in the same monospace
    font as the previous 'tcode' entry.

Index the two paragraphs that actually specify the rules for 'final'
and 'override' virt-specifiers applied to functions.

I chose to index these specifiers using the 'keyword' macro rather
than try to set up a separate indextext entry to ensure:
1) the index points to the right page if ever the paragraph splits
across pages
2) the form is consistent with every othert index entry for these
two contextual keywords, which are all created by 'keyword'
Visually confirmed that the text renders in the same monospace
font as the previous 'tcode' entry.
@jensmaurer jensmaurer merged commit d5e84cc into cplusplus:master Sep 8, 2020
zygoloid pushed a commit to zygoloid/cplusplus that referenced this pull request Sep 22, 2020
…plus#4139)

This indexes the two paragraphs that actually specify the rules for
'final' and 'override' applied to functions.
zygoloid pushed a commit to zygoloid/cplusplus that referenced this pull request Sep 22, 2020
…plus#4139)

This indexes the two paragraphs that actually specify the rules for
'final' and 'override' applied to functions.
zygoloid pushed a commit that referenced this pull request Sep 22, 2020
This indexes the two paragraphs that actually specify the rules for
'final' and 'override' applied to functions.
tkoeppe pushed a commit that referenced this pull request Sep 22, 2020
This indexes the two paragraphs that actually specify the rules for
'final' and 'override' applied to functions.
tkoeppe pushed a commit that referenced this pull request Sep 24, 2020
This indexes the two paragraphs that actually specify the rules for
'final' and 'override' applied to functions.
@AlisdairM AlisdairM deleted the index_virt_specifier_for_functions branch November 14, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants