Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diff.mods.to.declarations] Also mention 'byte' and 'to_integer. #4145

Merged
merged 1 commit into from Sep 8, 2020

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Sep 6, 2020

These names, as well as operators for std::byte, are part of .

Fixes #4144.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK. I think this is a normative change, because currently <stddef.h> is required to declare ::nullptr_t. That's how libstdc++ and libc++ interpret it (and MS STL too as far as I can tell).

C.6.3 [diffs.mods.to.declarations] is informative (not normative), and my interpretation is that it's saying "The C++ version of this header adds nullptr_t, which isn't in the C version of this header". It's not saying that <cstddef> declares it and C++'s <stddef.h> doesn't.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 6, 2020

You're right. Should we create an issue for this then? (I still think this is a desirable change, but it is indeed normative.)

I will replace the wording changes here with those for [diffs.mods.to.declarations].

These names, as well as operators for std::byte, are part of <cstddef>.
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 6, 2020

@jwakely: PTAL.

@tkoeppe tkoeppe changed the title [depr.c.header.others] Add 'std::nullptr_t' to the list of names NOT declared by stddef.h. [diff.mods.to.declarations] Also mention 'byte' and 'to_integer. Sep 6, 2020
@tkoeppe tkoeppe requested a review from jwakely September 8, 2020 12:25
@jensmaurer jensmaurer merged commit d27fe13 into cplusplus:master Sep 8, 2020
@tkoeppe tkoeppe deleted the nullptr branch September 8, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent description of C++ extensions to header <cstddef> LWG3484
3 participants