[macros] Fix PDF links to clauses and annexes #4154
Conversation
|
Looks good! Would you like me to test it? Otherwise if it works for you, feel free to commit. |
|
Please do, it doesn't work for me. |
|
Well, there is a bit of implementation-dependence here, because the "chapter.x" thing is modeled after what is produced by the regular \label. If your particular memoir or hyperref package writes something else there, this won't work. So, please try it out. If it doesn't work for you, please replace the single use of \clauselabel in macros.tex with plain \label and put the resulting first occurrence of \newlabel in basic.aux in this issue, for comparison. |
jensmaurer
force-pushed
the
jp015
branch
2 times, most recently
from
3d19803
to
1bb325a
Compare
|
Ok, I've now analyzed this some more and I've copied a little bit of the original (memoir) \label definition. This means fewer assumptions about href naming are made. |
Such links were pointing to immediately after the clause or annex title, not to immediately before them. The issue was introduced with commit beb8815. Fixes NB JP 014 and JP 015 (C++20 DIS)
|
I cherrypicked this onto the main branch, since the c++20 branch hasn't got the version update fix for one of the packages, and there it worked as intended for me. But it's possible that there are dependencies on unstable implementation details. |
|
@jensmaurer, @zygoloid: Could we perhaps cherrypick all the non-visible changes onto the c++20 branch (e.g. the version requirements), so that the "build environment" is the same for both? |
|
The new version of this change also works for me. |
|
@tkoeppe, consider approving this pull request if it works for you. |
|
Yes, it works now. |
Such links were pointing to immediately after the clause
or annex title, not to immediately before them. The issue
was introduced with commit beb8815.
Fixes NB JP 014 and JP 015 (C++20 DIS)
Fixes cplusplus/nbballot#390
Fixes cplusplus/nbballot#391