[conv.qual] Fix punctuation in bulleted list. #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Sep 18, 2020
source/expressions.tex
Outdated
| @@ -754,7 +754,7 @@ | |||
| \item | |||
| if the resulting $\cv{}^3_i$ is different from $\cv{}^1_i$ or $\cv{}^2_i$, | |||
| or the resulting $P^3_i$ is different from $P^1_i$ or $P^2_i$, | |||
| then \tcode{const} is added to every $\cv{}^3_k$ for $0 < k < i$. | |||
| then \tcode{const} is added to every $\cv{}^3_k$ for $0 < k < i$; | |||
There was a problem hiding this comment.
I think:
- This is connecting the bullets to the "where", so we don't need to use the same character as for the other bullets here. I'd expect a comma rather than a semicolon before a "where".
- We're missing an "and" at the end of the second bullet.
- It would be fine to use commas rather than semicolons for the first two bullets. The bullets are sufficient to indicate the structure here.
zygoloid
added
the
changes requested
jensmaurer
removed
the
changes requested
|
Fixed, rebased, and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4119