[over.literal] Mark use of a reserved identifier with 'error'. #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Sep 18, 2020
source/overloading.tex
Outdated
| @@ -4259,7 +4259,7 @@ | |||
| float operator ""_e(const char*); // OK | |||
| float operator ""E(const char*); // error: reserved literal suffix~(\ref{usrlit.suffix}, \ref{lex.ext}) | |||
| double operator""_Bq(long double); // OK: does not use the reserved identifier \tcode{_Bq}\iref{lex.name} | |||
| double operator"" _Bq(long double); // uses the reserved identifier \tcode{_Bq}\iref{lex.name} | |||
| double operator"" _Bq(long double); // error: uses the reserved identifier \tcode{_Bq}\iref{lex.name} | |||
There was a problem hiding this comment.
Do we say "error:" for "no diagnostic required" cases? I think we intentionally don't say "OK" or "error" here, because neither is guaranteed.
There was a problem hiding this comment.
At least, we do two lines earlier for ""E.
In other cases, we say "ill-formed, no diagnostic required" in the example comment.
Let's excise "error" here.
with 'ill-formed, no diagnostic required'. Also mark grammar terms as appropriate.
|
Fixed, rebased, and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4048