New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hanging paragraphs for C++20 #4169
Conversation
080f078
to
b2a60c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm creating an extension for tools/check.sh to detect hanging paragraphs using sed and awk.
@@ -2084,6 +2090,8 @@ | |||
\indextext{specifier|)}% | |||
|
|||
\rSec1[dcl.decl]{Declarators}% | |||
|
|||
\rSec2[dcl.decl.general]{General}% | |||
\indextext{declarator|(} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not nice; the "declarator" start of index range should probably be before the "General" section. But maybe this is not the right time to fiddle with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix this for the master
branch. I think this is fine for C++20.
b2a60c8
to
ba12e7c
Compare
Ah, we were both working on this at the same time. I built a perl script to do this; do you prefer one approach or the other? |
My check script is here: #4170 |
Maybe not:
Does your script fix this, @jensmaurer? |
I've marked as done those that will be fixed by this. Please, do check the others: #3525. |
Fixes ISO/CS 018 (C++20 DIS).
ba12e7c
to
d2112b9
Compare
For what it's worth, using |
@zygoloid , I think I'm not using GNU awk specifics, at least not in the "hanging paragraph" check. |
Sorry, you're right, it's |
Mechanically fix all hanging paragraphs by adding "General" sections.
For C++23, we should go through these and rename them as appropriate, but for C++20 let's just mechanically call them all "General" and name them [foo.general].
Fixes cplusplus/nbballot#394.