Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Foreword based on comments from ISO/CS #4171

Merged
merged 1 commit into from Sep 10, 2020

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Sep 9, 2020

Fix some minor discrepancies between our Foreword and the text provided by ISO/CS, and reduce the list of changes a bit.

Fixes cplusplus/nbballot#388.

@jensmaurer jensmaurer added this to the C++20 milestone Sep 9, 2020
@jensmaurer jensmaurer added the ballot-comment Response to an NB or ISO comment on a ballot label Sep 9, 2020
\item addition of synchronization facilities for
waiting, notifications, semaphores, latches, and barriers, and
\libheaderref{barrier}, \libheaderref{latch} and \libheaderref{semaphore} headers
\item addition of \libheaderref{barrier}, \libheaderref{latch} and \libheaderref{semaphore} headers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs an Oxford comma, I believe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and squashed a little more of the more-minor content out of this list.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more comma, please

list of main changes and remove some more minor items.

Fixes ISO/CS 012 (C++20 DIS).
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants