Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overfull \hbox; bugfix for check script #4173

Merged
merged 2 commits into from Sep 9, 2020

Conversation

jensmaurer
Copy link
Member

No description provided.

@jensmaurer
Copy link
Member Author

@zygoloid , the remaining hanging paragraphs are:

\rSec1[expr.prim]{Primary expressions}% <-- Hanging paragraph follows
\rSec2[fpos]{Class template \tcode{fpos}} <-- Hanging paragraph follows
\rSec3[back.insert.iterator]{Class template \tcode{back_insert_iterator}} <-- Hanging paragraph follows
\rSec3[front.insert.iterator]{Class template \tcode{front_insert_iterator}} <-- Hanging paragraph follows
\rSec3[insert.iterator]{Class template \tcode{insert_iterator}} <-- Hanging paragraph follows
\rSec3[locale.time.put]{Class template \tcode{time_put}} <-- Hanging paragraph follows
\rSec3[locale.money.get]{Class template \tcode{money_get}} <-- Hanging paragraph follows
\rSec3[locale.money.put]{Class template \tcode{money_put}} <-- Hanging paragraph follows
\rSec3[coroutine.handle.noop]{Class \tcode{coroutine_handle<noop_coroutine_promise>}} <-- Hanging paragraph follows
\rSec2[tuple.tuple]{Class template \tcode{tuple}} <-- Hanging paragraph follows

This is mostly standard library class synopses etc. There is no \pnum, so your script didn't detect them.

@zygoloid
Copy link
Member

zygoloid commented Sep 9, 2020

This is mostly standard library class synopses etc. There is no \pnum, so your script didn't detect them.

I intentionally skipped these. If there are no paragraphs, then I think by definition there are no hanging paragraphs, and I don't think we want subclauses containing no paragraph numbers. The check I wanted was "is there a \pnum between two \rSecs with increasing level?"

That said: in the longer term (for C++23) it would be a good idea to fix these remaining cases.

@zygoloid zygoloid merged commit b319010 into cplusplus:c++20 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants