Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solitary subclauses #4178

Merged
merged 1 commit into from Sep 10, 2020
Merged

Fix solitary subclauses #4178

merged 1 commit into from Sep 10, 2020

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Sep 10, 2020 •
edited by jensmaurer

ISO/CS comment 018 on the C++20 DIS requests that we avoid subclauses with no siblings.

Merging this to master will address #3525.

Fixes cplusplus/nbballot#394

@zygoloid
Fix solitary subclauses.
ed385ec 
ISO rules don't permit us to have a subclause with no siblings. We had
six of these, for various reasons. Fold them together or add more
subclauses to un-isolate.

For ISO/CS 018 (C++20 DIS).
jensmaurer
jensmaurer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zygoloid zygoloid merged commit fd16e43 into cplusplus:c++20 Sep 10, 2020
@zygoloid zygoloid mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zygoloid @jensmaurer