Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solitary subclauses #4186

Merged
merged 1 commit into from Sep 10, 2020
Merged

Fix solitary subclauses #4186

merged 1 commit into from Sep 10, 2020

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Sep 10, 2020 •
edited

Merge of #4178 to master.

Fixes #3525.

@zygoloid
Fix solitary subclauses.
e9d54d0 
ISO rules don't permit us to have a subclause with no siblings. We had
six of these, for various reasons. Fold them together or add more
subclauses to un-isolate.

For ISO/CS 018 (C++20 DIS).
@zygoloid zygoloid merged commit 42f74e4 into cplusplus:master Sep 10, 2020
@JohelEGP
Copy link
Contributor

This missed https://github.com/cplusplus/draft/pull/4178/files#diff-601602f584c2b79724118aad6ebef4ae (delta [unreachable.sentinels]).

@jensmaurer
Copy link
Member

jensmaurer commented Sep 10, 2020 •
edited

I don't understand. When we introduce a new section, we don't add an entry to xrefdelta.

@JohelEGP
Copy link
Contributor

Do you mean that the [unreachable.sentinels] entry shouldn't have been there? I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[std] There shall be no .1 subclause without a .2 sibling
3 participants
@zygoloid @JohelEGP @jensmaurer