New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[everywhere] Follow ISO rules for the presentation of notes and examples #4190
Conversation
cf9bf84
to
09eb79f
Compare
Note that this adds an overfull vbox somewhere in Clause 23, but I've not been able to determine what it's referring to yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor stuff
source/layout.tex
Outdated
{\parabullnum{Paras}{0pt}} | ||
% Register our intent to number the next paragraph. Don't actually number it | ||
% yet, because we might have a paragraph break before we see its contents (for | ||
% example, if the paragraph beings with a note or example). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beings -> begins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
source/macros.tex
Outdated
@@ -634,4 +641,6 @@ | |||
\let\addcontentsline\oldcontentsline% | |||
} | |||
\newcommand{\defncontext}[1]{\textlangle#1\textrangle} | |||
\newenvironment{defnote}{\addtocounter{termnote}{1}\noteintro{Note \thetermnote{} to entry}}{\noteoutro{note}\space} | |||
\newenvironment{defnote} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it, shouldn't this get a \par in front, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and duplication between this and note/example eliminated too.
Overfull \vbox: Maybe it's the longtable in [bidirectional.iterators]. Its bottom part looks very close to the footer. |
move them to (un-numbered) paragraphs of their own. Partially addresses ISO/CS 016 (C++20 DIS).
in the middle of the interval "[E000, 10FFFF]".
Fixes an overfull hbox and reduces the risk of tables running off the bottom of the page.
Yes, looks like that was it. Fixed. |
Number notes and examples, make them one point smaller, and move them to (un-numbered) paragraphs of their own.
Partially addresses ISO/CS 016 (C++20 DIS).
Fixes cplusplus/nbballot#398.