[intro.defs] Remove cross-references to main part #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
approved these changes
Sep 10, 2020
zygoloid
reviewed
Sep 11, 2020
Comment on lines
-124
to
-115
| read\iref{conv.lval} or | ||
| modify (\ref{expr.ass}, \ref{expr.post.incr}, \ref{expr.pre.incr}) | ||
| the value of an object |
There was a problem hiding this comment.
Can we add some text to the note below to retain these useful xrefs? Perhaps add between the first and second sentence:
Reads of scalar objects are described in \ref{conv.lval} and modifications of scalar objects are describred in \ref{expr.ass}, \ref{expr.post.incr}, and \ref{expr.pre.incr}.
I think it's important to the use of this definition that we know what these four cases are.
source/intro.tex
Outdated
Comment on lines
346
to
347
| templates that take two template arguments | ||
| and are declared in header \libheader{iosfwd} |
There was a problem hiding this comment.
Can we keep the two conditions the other way around? It makes more sense to me to start with all templates in <iosfwd> and then filter by "takes two arguments" than to start with the universe of all templates taking two arguments and then filter by "declared in <iosfwd>".
Definitions of terms cannot refer to subclauses in the main body of the standard. Partially addresses ISO/CS 016 (C++20 DIS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses ISO/CS 016 (C++20 DIS)
Fixes cplusplus/nbballot#397