Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insert_or_assign (23.5.4.4p7 and 23.4.4.4p5) reference undefined "args" #422

Closed
cubbimew opened this issue Dec 17, 2014 · 2 comments
Closed

insert_or_assign (23.5.4.4p7 and 23.4.4.4p5) reference undefined "args" #422

cubbimew opened this issue Dec 17, 2014 · 2 comments

Comments

@cubbimew
Copy link
Contributor

Both map::insert_or_assign 23.4.4.4[map.modifiers]p5 and unordered_map::insert_or_assign 23.5.4.4[unord.map.modifiers]p7 refer to undefined name "args" in their Effects: clauses. This appears to be an editorial mistake made in n4279 when applying one of the several changes this interface went through.

I believe
"constructed from the arguments as value_type(k, std::forward<Args>(args)...)" should be changed to "constructed from the arguments as value_type(k, std::forward<M>(obj))" as it was in n3873 to begin with, and the same for the std::move(k) versions.
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 18, 2014

Thanks! I've already been alerted to this problem recently and an issue is underway. The one you mentioned is just a simple editorial error; there's a more serious one in try_emplace, where the effect should really read:

value_type(piecewise_construct,
           forward_as_tuple(k),
           forward_as_tuple(forward<Args>(args)...))

We're on it :-)

@cubbimew
Copy link
Contributor Author

fixed over a year ago by 68cc1bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoeppe @cubbimew