Yet more cherry-picks for c++20 #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... suggesting that the more common plain "object type" means something different.
to match [counted.iter.cust]
|
I might perhaps like to drop the "wrap synopsis in namespace" commit, just because it's a bit large. |
It's large, but if you ignore whitespace ( --- a/source/strings.tex
+++ b/source/strings.tex
@@ -4020,9 +4020,10 @@ are available when \tcode{<string_view>} is included.
\indexlibrarymember{size_type}{basic_string_view}%
\indexlibrarymember{difference_type}{basic_string_view}%
\begin{codeblock}
-template<class charT, class traits = char_traits<charT>>
-class basic_string_view {
-public:
+namespace std {
+ template<class charT, class traits = char_traits<charT>>
+ class basic_string_view {
+ public:
// types
using traits_type = traits;
using value_type = charT;
@@ -4125,14 +4126,15 @@ public:
size_type n) const;
constexpr size_type find_last_not_of(const charT* s, size_type pos = npos) const;
-private:
+ private:
const_pointer data_; // \expos
size_type size_; // \expos
-};
+ };
-// \ref{string.view.deduct}, deduction guide
-template<class It, class End>
+ // \ref{string.view.deduct}, deduction guide
+ template<class It, class End>
basic_string_view(It, End) -> basic_string_view<iter_value_t<It>>;
+}
\end{codeblock}
\pnum |
jwakely
approved these changes
Sep 23, 2020
|
After this speculative PR, the remaining unused commits would be as follows: |
jensmaurer
approved these changes
Sep 23, 2020
|
I added dd52b47 to this PR. |
zygoloid
approved these changes
Sep 24, 2020
|
@jwakely posted a diff that disregards whitespace and shows that this is really just adding the namespace and indenting everything inside. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwakely, @CaseyCarter your input is most welcome. See also #4220 (comment) for a complete list of candidate commits.