Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page breaks (jmaurer) #4231

Merged
merged 8 commits into from Oct 2, 2020
Merged

Page breaks (jmaurer) #4231

merged 8 commits into from Oct 2, 2020

Conversation

jensmaurer
Copy link
Member

Partially addresses #4228

@zygoloid
Copy link
Member

zygoloid commented Oct 1, 2020

26.8: I wonder if we could keep the foo, fool, foof overloads together on the same page. Not a big deal, though, and I don't think we should do this for C++20.

32.5.4.4.2: The widowed class-head is unfortunate. But I think we can live with this if a newpage here causes problems. (Similar in 32.5.5.3, but I think that'd be too much to add a newpage before if fixing 32.5.4.4.2 doesn't affect it.)

32.9.10.2/17: I think we should move the "Error conditions:" line onto the next page with its bullets.

Other than that, Clause 25-32 look good. Thanks!

@jensmaurer
Copy link
Member Author

jensmaurer commented Oct 1, 2020

I've addressed the [thread.] stuff. Regrettably, there was quite a bit of fall-out; needs re-review. Force-pushed.

Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@zygoloid zygoloid merged commit 914092d into cplusplus:c++20 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants