[futures.async] Avoid note within a sentence. #4232
Conversation
source/threads.tex
Outdated
| @@ -7184,6 +7180,11 @@ | |||
| \end{note} | |||
There was a problem hiding this comment.
What about this other note -- would it also work better outside the list?
There was a problem hiding this comment.
Maybe. I'm trying to limit the size of the changes this late in the process.
There was a problem hiding this comment.
We could further limit the size of the changes by turning these bullets into proper sentences. (There's already a period before the first note.) Eg:
Synchronization: The following apply regardless of the provided
policyargument:
- The invocation of
asyncsynchronizes with the invocation off.
[Note:...]- The completion of the function
fis sequenced before the shared state is made ready.
[Note:...]
For master we could be a bit more aggressive:
Synchronization: The invocation of
asyncsynchronizes with the invocation off. The completion of the functionfis sequenced before the shared state is made ready.
[Note: These apply regardless of the providedpolicyargument, and even if the correspondingfutureobject is moved to another thread. However,fmight not be called at all, so its completion might never happen.]
There was a problem hiding this comment.
I like both parts of this.
|
This is now the minimal fix against C++20. Please check. |
|
The larger fix for C++23 is in #4244. |
Partially addresses #4228
After this is merged, check page break in [futures.task.members].