Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[std] Introduce tailnote environment to avoid empty lines in tables. #4249

Merged
merged 1 commit into from Sep 29, 2020
Merged

[std] Introduce tailnote environment to avoid empty lines in tables. #4249

merged 1 commit into from Sep 29, 2020
+24 −20

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Sep 29, 2020 •
edited

Partially addresses #4228.

This should also be applied to master.

@jensmaurer jensmaurer changed the title [std] Avoid empty line after note in table. [std] Introduce note* environment to avoid empty lines in tables. Sep 29, 2020
@jensmaurer jensmaurer added this to the C++20 milestone Sep 29, 2020
@jensmaurer jensmaurer mentioned this pull request Sep 29, 2020
Closed
burblebee
burblebee approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pick a more meaningful name than note*? otherwise looks good

@jensmaurer jensmaurer changed the title [std] Introduce note* environment to avoid empty lines in tables. [std] Introduce tailnote environment to avoid empty lines in tables. Sep 29, 2020
@jensmaurer
Copy link
Member Author

This is for c++20 and for "master".

@burblebee burblebee merged commit a7282c2 into cplusplus:c++20 Sep 29, 2020
@jensmaurer
Copy link
Member Author

Cherry-picked and merged to master.

jensmaurer added a commit that referenced this pull request Sep 29, 2020
@jensmaurer
[std] Introduce tailnote environment to avoid empty lines in tables. (#…
098f449 
…4249)
@jensmaurer jensmaurer mentioned this pull request Sep 29, 2020
Closed
jensmaurer added a commit that referenced this pull request Sep 30, 2020
@jensmaurer
[std] Introduce tailnote environment to avoid empty lines in tables. (#…
9d70fd2 
…4249)
jensmaurer added a commit that referenced this pull request Sep 30, 2020
@jensmaurer
[std] Introduce tailnote environment to avoid empty lines in tables. (#…
a2f42e5 
…4249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burblebee burblebee burblebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
C++20 IS
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jensmaurer @burblebee