Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page breaks (burblebee) #4252

Merged
merged 16 commits into from Oct 2, 2020
Merged

Page breaks (burblebee) #4252

merged 16 commits into from Oct 2, 2020

Conversation

zygoloid
Copy link
Member

Partially addresses #4228

@zygoloid zygoloid marked this pull request as draft September 30, 2020 19:46
@burblebee burblebee force-pushed the c++20_tweaks branch 4 times, most recently from dc41e4d to 7130f45 Compare September 30, 2020 21:06
@burblebee
Copy link
Contributor

burblebee commented Sep 30, 2020

These changes should also be applied to master:

  • d73b1b5 [tab:meta.trans.other] Remove blank line before Preconditions.
  • f5e6a98 [tab:container.hash.req] Add line breaks before next itemdecl clause.
  • 3e29511 [temp.dep.type] Replace note in sentence with footnote.
  • 1edf52d [expr.const] Replace notes in sentences with footnotes.

If we can't figure out what is causing the spurious blank line, we'll also want to merge this which removes the \br; alternatively, \br could be replaced with \par:

  • 8ac85dd [tab:container.seq.opt] Remove blank line in the description of emplace_back.

@zygoloid
Copy link
Member Author

zygoloid commented Oct 1, 2020

Please remove the "partially addresses" note from the individual commit messages. We want that on the pull request, not in the commit messages.

@burblebee
Copy link
Contributor

Please remove the "partially addresses" note from the individual commit messages. We want that on the pull request, not in the commit messages.

done.

@zygoloid
Copy link
Member Author

zygoloid commented Oct 2, 2020

[temp.dep.type]p9 has a mid-sentence note.

Consider adding a page break before [cpp.replace.general]p10

Please see if you can move the declarations before [new.delete.single]p10 all onto the same page without reflowing that page -- it looks like there might be enough white space at the bottom for that. If it doesn't fit, try putting two of the declarations on each page instead.

[string.view.synop] would probably benefit from a page break before. The #include looks lonely.

There's a spurious line break in table [tab:container.seq.opt] in the description of emplace_back, before "Returns:".

Otherwise, looks good. Thanks!

@burblebee
Copy link
Contributor

I fixed all the issues you raised above.

There's a spurious line break in table [tab:container.seq.opt] in the description of emplace_back, before "Returns:".

I can't explain this one - looks like a bug in Latex, triggered when a sentence ends at the column boundary and is followed by \br. It could trip us up elsewhere, so worth looking into. I went ahead and removed the \br from the previous itemdecl clause to fix.

@zygoloid zygoloid marked this pull request as ready for review October 2, 2020 19:48
source/templates.tex Outdated Show resolved Hide resolved
@zygoloid
Copy link
Member Author

zygoloid commented Oct 2, 2020

Thanks, looks great! (I can't actually approve because I created this PR, but... approved!)

@zygoloid zygoloid merged commit cc27dd7 into c++20 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants