Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++20 tweaks #4275

Merged
merged 3 commits into from Oct 5, 2020
Merged

C++20 tweaks #4275

merged 3 commits into from Oct 5, 2020

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Oct 3, 2020 •
edited

Build fix:

  • 3035313 [tab:container.alloc.req] Indent clauses to fix the build.

Optional fixes:

  • 727aff3 [locale.codecvt] Use 2 space indentation (but leave inconsistent indentation for parameters in synopsis as is).
  • 6ab8897 [time.clock.cast.fn] Use 2 space indentation in the constraints for clock_cast.

burblebee
burblebee commented Oct 3, 2020
View reviewed changes
source/locales.tex
@@ -1802,18 +1802,18 @@
explicit codecvt(size_t refs = 0);

result out(
stateT& state,
const internT* from, const internT* from_end, const internT*& from_next,
externT* to, externT* to_end, externT*& to_next) const;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zygoloid Should we fix the parameters as well? I would, but the current indentation does make the differences between these functions more obvious.

@zygoloid zygoloid mentioned this pull request Oct 5, 2020
Closed
@burblebee burblebee marked this pull request as ready for review October 5, 2020 07:28
@burblebee burblebee force-pushed the c++20_tweaks branch 2 times, most recently from ea2c34a to 70e4b06 Compare October 5, 2020 09:59
@burblebee burblebee marked this pull request as draft October 5, 2020 10:03
@burblebee burblebee changed the base branch from c++20 to master October 5, 2020 10:08
@burblebee burblebee force-pushed the c++20_tweaks branch 2 times, most recently from c50a15d to f6d83b7 Compare October 5, 2020 17:53
@burblebee burblebee marked this pull request as ready for review October 5, 2020 18:05
@zygoloid zygoloid merged commit 2f84fa4 into master Oct 5, 2020
@zygoloid zygoloid deleted the c++20_tweaks branch October 5, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid Awaiting requested review from zygoloid

@jensmaurer jensmaurer Awaiting requested review from jensmaurer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burblebee @zygoloid