[dcl.fct] Clarify which declarations we're talking about in example. #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkoeppe I think this worked, yes? The issue was I had to use https://github.com/burblebee/draft.git instead of git@github.com:burblebee/draft.git because my username locally is different from github's. |
|
@burblebee: yes, looks like it worked! |
tkoeppe
approved these changes
Oct 7, 2020
|
Add-on improvement suggestion: We should somehow say that g1 is compared against g1 etc. Maybe add "corresponding" or "respective" somewhere. As it stands, it might be misread as-if all of the declarations are mutually functionally equivalent, but they're not. |
zygoloid
added
the
changes requested
|
Apparently, the Project Editor supports my change suggestion. Please augment this pull request accordingly. |
burblebee
removed
the
changes requested
jensmaurer
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes "These declarations" to "The declarations above" inn example so it's clear which declarations we're talking about.