Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stmt.ranged] Align font for begin-expr and end-expr. #4289

Merged
merged 1 commit into from Oct 29, 2020

Conversation

jensmaurer
Copy link
Member

Those are placeholders for expressions.

Fixes #4285

@zygoloid zygoloid requested a review from tkoeppe October 18, 2020 03:21
@zygoloid
Copy link
Member

@tkoeppe I'd like your opinion on the cacophony of fonts in use here. We have upright text, slanted grammar terms, italicized placeholders, teletype code, and slanted teletype exposition-only IDs, in a short space. And the teletype font have rather different font weight when used in the codeblock and when used in running text (eg, in bullets (1.2) and (1.3.2)).

The use of grammarterm for the begin-expr and end-expr is certainly wrong, but I wonder if there's more here that we could improve.

@tkoeppe tkoeppe self-assigned this Oct 18, 2020
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 18, 2020

I'll take a look. I had similar thoughts when the issue was first raised.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 18, 2020

(Tangent: I think the font weight of the slanted teletype is always quite big, even in the codeblock. There's just less roman font around for comparison. We can look into that separately. [Edit] I don't think we can get a ligher weight of that font easily. However, we might be able to lighten the literal colour, like we did with the grammar; in fact, the grammary-gray seems to work nicely for this.)

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 18, 2020

I wouldn't be opposed to more "slanted teletype" for these expression placeholders. Nothing says we can use that style only for placeholder variables, and indeed we areadly happily use it for placeholder types and concepts I believe.

Copy link
Contributor

@tkoeppe tkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we could use \exposid everywhere for the two expr-placeholders and it wouldn't look all that confusing. We already use italic-teletype for a variety of placeholders (concepts, namespaces, types), so I don't have a problem with also using it for expressions.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 28, 2020

@jensmaurer: Looks like something went wrong with the push, could you check again?

Those are placeholders for expressions.
@jensmaurer
Copy link
Member Author

@tkoeppe , should be better now.

@jensmaurer jensmaurer merged commit fa67415 into cplusplus:master Oct 29, 2020
@jensmaurer jensmaurer deleted the c35 branch October 29, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stmt.ranged] Inconsistent placeholder formatting
3 participants