Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[layout] Make "small" line spacing equal to normal spacing. #4293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Oct 7, 2020

Now "normal" is 10pt/12pt (as it has always been) and "small" is
9pt/12pt. This makes notes and examples use the same line spacing as
the ambient text.

image

Left: new, right: before.

@jensmaurer
Copy link
Member

Hm... I think I like that notes are smaller in all directions. I think they should be separate from the next paragraph by full-size vertical space, but the internal spacing should be smaller so that the text sticks together naturally.

@burblebee
Copy link
Contributor

With 9/12 font for notes, the note by itself it doesn't look bad, but when seen in context with regular text, the proportionally greater vertical space stands out. I much prefer the 9/10.5 spacing.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 8, 2020

Try to consider this in the wider context. With the smaller line height, the overall vertical rhythm is more uneven as you go into and out of notes, which makes the page look wobbly and tentative. By contrast, with the fixed spacing everything looks regular and calm and even.

That's certainly fairly subjective, but I'd like to encourage you to look at this again with that in mind. That is, don't just look at an individual note, but see how the whole document looks as you leaf through page after page.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 8, 2020

For an example, try out the page with the [class.prop] heading. It has two notes just before the heading. I find the "evenly spaced" style quite nice here, and somehow "less surprising" than the narrower style of the status quo. Likewise for notes in the middle of lists, e.g. [over.match.oper]b(3.4). Another nice example is [over.match.copy]p1, which has a note in the middle. I find the even spacing very nice here.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 13, 2020

Here's a nice mix of notes and normative text:

image

@zygoloid zygoloid added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 13, 2020
@zygoloid
Copy link
Member

This change makes notes and examples less visually distinct. We should decide whether or not that's a goal.

Our friends in WG14 use smaller inter-line spacing within notes and examples (and, presumably uncontroversially, both documents use less inter-line spacing in footnotes).

@jensmaurer
Copy link
Member

Personally, I think the smaller inter-line spacing is preferable, exactly because it sets notes and examples apart visually from the normative text, and a smaller inter-line spacing does fit the smaller font.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 14, 2020

Would you perhaps be willing to do a little experiment and use this patch for a couple of days of "regular work" with the Standard, where you read it as a normal user, not an editorial reviewer?

I wonder if there's just the familiarity with the status quo, or the particular focus on reworking notes, that makes it so desirable to distinguish notes from non-notes in so many ways, and whether this is really something a regular reader would want. Also please consider whether you would have asked for the spacing to be made narrower if this even spacing had always been like this since the beginning.

Now "normal" is 10pt/12pt (as it has always been) and "small" is
9pt/12pt. This makes notes and examples use the same line spacing as
the ambient text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision-required A decision of the editorial group (or the Project Editor) is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants