[rand.eng], [rand.adapt] Use maths to describe relations between constants #4295
+33
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wg21bot
added
the
needs rebase
jwakely
force-pushed
the
rand.eng-moar-maths
branch
from
caeb8c3 to
5383a93
Compare
jwakely
removed
the
needs rebase
|
@jwakely, @CaseyCarter, @W-E-Brown: I would love to land this change. It would leave a lot less to the imagination and make it clear how the code variables relate to the maths variables. Any final thoughts? |
|
I still like this change. It might be even better if we used something like D for |
3 tasks
wg21bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4292
I know that "unless otherwise specified" is strictly unnecessary in the blanket wording, but I think it helps here. In [rand.eng.lcong] we have:
That specifies m for the
m==0case, but the blanket wording applies for all other values ofm.