Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread.stoptoken.intro] Fix typo #4301

Closed
wants to merge 1 commit into from

Conversation

StephanTLavavej
Copy link
Contributor

@StephanTLavavej StephanTLavavej commented Oct 21, 2020

[thread.stoptoken.intro] Fix typo by changing “asynchonously” to “asynchronously”.

@JohelEGP
Copy link
Contributor

The commit message needs to beginstart with [thread.stoptoken.intro].

@StephanTLavavej StephanTLavavej changed the title Fix typo: asynchonously => asynchronously [thread.stoptoken.intro] Fix typo Oct 21, 2020
@StephanTLavavej
Copy link
Contributor Author

Done, thanks.

@jwakely
Copy link
Member

jwakely commented Oct 21, 2020

Could you please edit the actual commit to add it? That's what goes in the commit log, not the pull request text.

Assuming you have a local clone, git commit --amend and add the stable name, then git push --force-with-lease blah fix-typo to the relevant blah remote. But if you just edited it through the github web UI then I can take care of amending it and merging it.

@jwakely
Copy link
Member

jwakely commented Oct 21, 2020

I went and did it locally and pushed as 5555ec3

@jwakely jwakely closed this Oct 21, 2020
@StephanTLavavej StephanTLavavej deleted the fix_typo branch October 22, 2020 00:51
@StephanTLavavej
Copy link
Contributor Author

Thanks @jwakely, I'll remember that for the future. (Over in microsoft/STL we edit the commit message when squashing a PR, so I wasn't expecting the actual commit to matter here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants