[expr] Use 'qualification-combined' and 'qualification-decomposition'. #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jensmaurer: Do you think changing the terms-of-art here is sufficiently editorial? |
|
I could ask CWG in their next meeting, to make sure. |
|
@jensmaurer: Yes please, I would welcome that. I can compile a list of high-interest GitHub issues if you like. The change looks valuable, but it'd be good to have some official sign-off. |
|
Put on CWG's plate: |
|
2021-05-03 decomposition -> qualification-decomposition |
jensmaurer
added
changes requested
The previous names 'cv-combined' and 'cv-decomposition' are no longer adequate since a qualification conversion can now convert to an array of unknown bounds.
jensmaurer
removed
the
changes requested
jensmaurer
changed the title
|
@tkoeppe, this should be ready now. |
|
Thanks, I'll take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous names 'cv-combined' and 'cv-decomposition' are
no longer adequate since a qualification conversion can now
convert to an array of unknown bounds.
Fixes #3088