[time.clock.gps.members]/2 return type typo #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returns specification for `gps_clock::to_utc` says `gps_time` instead of `utc_time`, probably a copy-paste typo from p3. The original proposal, P0355R7, also says `gps_time`, but the intent seems obvious, and the status quo doesn't compile.
jensmaurer
approved these changes
Nov 7, 2020
StephanTLavavej
approved these changes
Nov 19, 2020
|
@tkoeppe I was just wondering, since this is my first PR here, if there's anything else I need to do to get it merged? Thanks. |
|
@MattStephanson , there are no changes requested from you. However,
Sorry for us taking so long. |
jwakely
approved these changes
Dec 14, 2020
|
Indeed -- thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returns specification for
gps_clock::to_utcsaysgps_timeinstead ofutc_time, probably a copy-paste typo from p3. The original proposal, P0355R7, also saysgps_time, but the intent seems obvious, and the status quo doesn't compile.