New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[syncstream.syncbuf.cons] Remove bogus rdbuf() calls #4333

Merged

tkoeppe merged 1 commit into cplusplus:master from jwakely:syncbuf.cons

Dec 15, 2020

Member

jwakely commented Nov 10, 2020

You don't call rdbuf() to get to the streambuf, this type is the streambuf.


          [syncstream.syncbuf.cons] Remove bogus rdbuf() calls

d782d88

You don't call rdbuf() to get to the streambuf, this type is the streambuf.

tkoeppe requested a review from CaseyCarter

November 10, 2020 22:22

Contributor

tkoeppe commented Dec 14, 2020

@CaseyCarter: Could you kindly take a look?

jensmaurer approved these changes

View reviewed changes

tkoeppe merged commit dfb01cd into cplusplus:master

jwakely deleted the syncbuf.cons branch

January 22, 2022 09:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment