Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[time] Replace 'could' and 'might' #4336

Merged
merged 1 commit into from Nov 12, 2020
Merged

Conversation

jensmaurer
Copy link
Member

as directed by ISO/CS.

Partially addresses #4319

as directed by ISO/CS.
that returns a \tcode{sys_info} where \tcode{save == 0min}.
There is no guarantee what \tcode{time_point} might return such a \tcode{sys_info}
There is no guarantee
what \tcode{time_point} (if any) returns such a \tcode{sys_info}
Copy link
Member

@jwakely jwakely Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this last sentence hard to understand (before and after this change).

I think this retains the meaning:

For any given time_zone, it is possible that there is no time_point that returns a sys_info not on daylight saving time. If such a time_point does exist, it is guaranteed not to be in the range [begin,end) of any sys_info on daylight saving time.

I also think "querying the time_zone could be more precise, by referring to the get_info member.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think any such larger rework is for C++23. Added to #4340.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely If you're happy with the suggested approach (this change for C++20, something else for C++23), please can you approve or merge this PR?

@zygoloid zygoloid merged commit 99dac1c into cplusplus:c++20 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants