[input.output] Replace 'could' and 'might' #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
reviewed
Nov 11, 2020
zygoloid
reviewed
Nov 12, 2020
source/iostreams.tex
Outdated
| @@ -15201,7 +15202,7 @@ | |||
| For POSIX-based operating systems, | |||
| \tcode{absolute(p)} is simply \tcode{current_path()/p}. | |||
| For Windows-based operating systems, | |||
| \tcode{absolute} might have the same semantics as \tcode{GetFullPathNameW}. | |||
| \tcode{absolute} can have the same semantics as \tcode{GetFullPathNameW}. | |||
There was a problem hiding this comment.
I don't think we're talking about ability or capability here; rather, we're talking about possibility. Given https://github.com/microsoft/STL/blob/master/stl/inc/filesystem#L3001, I think we can be so bold as to say:
Suggested change
| \tcode{absolute} can have the same semantics as \tcode{GetFullPathNameW}. | |
| \tcode{absolute} typically has the same semantics as \tcode{GetFullPathNameW}. |
There was a problem hiding this comment.
Ahem, there are two implementations that support Windows :-) But the other one also uses GetFullPathNameW here.
source/iostreams.tex
Outdated
| @@ -15762,7 +15763,7 @@ | |||
| \pnum | |||
| \begin{note} | |||
| The current path as returned by many operating systems is a dangerous | |||
| global variable. It might be changed unexpectedly by third-party or system | |||
| global variable. It can be changed unexpectedly by third-party or system | |||
There was a problem hiding this comment.
The second sentence isn't true in isolation -- we don't know that it can be changed asynchronously. How about this:
Suggested change
| global variable. It can be changed unexpectedly by third-party or system | |
| global variable, and can be changed unexpectedly by third-party or system |
source/iostreams.tex
Outdated
| @@ -15789,7 +15790,7 @@ | |||
| \pnum | |||
| \begin{note} | |||
| The current path for many operating systems is a dangerous | |||
| global state. It might be changed unexpectedly by a third-party or system | |||
| global state. It can be changed unexpectedly by a third-party or system | |||
There was a problem hiding this comment.
Suggested change
| global state. It can be changed unexpectedly by a third-party or system | |
| global state, and can be changed unexpectedly by a third-party or system |
source/iostreams.tex
Outdated
| A postcondition of \tcode{last_write_time(p) == new_time} is not specified since it might not hold for file systems | ||
| with coarse time granularity. | ||
| A postcondition of \tcode{last_write_time(p) == new_time} is not specified | ||
| since it does not necessarily hold for file systems with coarse time granularity. |
There was a problem hiding this comment.
Suggested change
| since it does not necessarily hold for file systems with coarse time granularity. | |
| because it does not necessarily hold for file systems with coarse time granularity. |
(Drive-by: use "since" only when dealing with time, and "because" for causality.)
as directed by ISO/CS.
|
All fixed and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as directed by ISO/CS.
Partially addresses #4319