[re] Replace 'could' and 'might' #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
reviewed
Nov 11, 2020
jwakely
approved these changes
Nov 12, 2020
zygoloid
reviewed
Nov 12, 2020
source/regex.tex
Outdated
| @@ -869,7 +869,7 @@ | |||
| \tcode{error_stack} | |||
| & | |||
| There was insufficient memory to determine whether the regular | |||
There was a problem hiding this comment.
Please convert all the entries in this table into the present tense. (This is another one of ISO/CS's requests, and in this case I think it's reasonable.) That'd also let us replace "would match" with "matches" here without losing the hypothetical feeling.
as directed by ISO/CS. Also turn past tense used for error conditions into present tense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as directed by ISO/CS.
Partially addresses #4319