[over] Replace 'could' and 'might' #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Nov 13, 2020
source/overloading.tex
Outdated
| @@ -2161,7 +2161,7 @@ | |||
| that | |||
| \tcode{W} | |||
| did not face | |||
| might be at least as good as | |||
| can be at least as good as | |||
There was a problem hiding this comment.
I don't think "can" really works here. How about:
"Although it is possible that another function F that W did not face is at least as good as W, ..."
source/overloading.tex
Outdated
Comment on lines
4202
to
4204
| function or function template (it can be a friend | ||
| function\iref{class.friend}), an explicit instantiation or specialization of a | ||
| function template, or a \grammarterm{using-declaration}\iref{namespace.udecl}. |
There was a problem hiding this comment.
"can" makes it sound like this is an exhaustive list, as if "it can be ..., and nothing else". This seems a little better:
Suggested change
| function or function template (it can be a friend | |
| function\iref{class.friend}), an explicit instantiation or specialization of a | |
| function template, or a \grammarterm{using-declaration}\iref{namespace.udecl}. | |
| function or function template (for example, it can be a friend | |
| function\iref{class.friend}), an explicit instantiation or specialization of a | |
| function template, or a \grammarterm{using-declaration}\iref{namespace.udecl}. |
as directed by ISO/CS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as directed by ISO/CS.
Partially addresses #4319