New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lex] Replace 'could' and 'might' #4366
Conversation
source/lex.tex
Outdated
\tcode{0xe}, \tcode{+}, and \tcode{foo} can produce a valid expression (for example, | ||
if \tcode{foo} were a macro defined as \tcode{1}). Similarly, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we keep "can" here, then I think the parenthetical needs to say "is", not "were".
Alternatively, could we say "would be able to produce"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with either. I'm a little worried that ISO will decide to declare "would" as verboten next (the upcoming revised Directives disallow use of any verbal forms not explicitly permitted, which would disallow "would"). But we can face that if and when it happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed to "is"
We need to be able to talk about hypotheticals in proper English phrasing, that includes "could" and "were" and "would" and "might". Everything else is just stupid.
(I agree with some of the -> can changes we have been doing; they seem to be clear improvements occasionally.)
source/lex.tex
Outdated
@@ -362,7 +362,7 @@ | |||
|
|||
\item Otherwise, | |||
the next preprocessing token is the longest sequence of | |||
characters that could constitute a preprocessing token, even if that | |||
characters that would constitute a preprocessing token, even if that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure "would" works here. Second options? @zygoloid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a bunch of max-munch rules that all follow the same pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then maybe this is fine as is (likewise below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I've been suggesting in other PRs is:
"longest sequence of characters that matches the syntax of a preprocessing-token"
... which seems more precise than our prior wording in the various tentative parsing areas, and distinguishes between matching the syntax of X and actually forming a valid X, without getting into hypotheticals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
182bcfc
to
6a28d90
Compare
as directed by ISO/CS.
as directed by ISO/CS.
Partially addresses #4319