Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using less excessively large source files #4369

Closed
Eelis opened this issue Nov 13, 2020 · 2 comments
Closed

Consider using less excessively large source files #4369

Eelis opened this issue Nov 13, 2020 · 2 comments
Projects
C++23 clause renumbering
Milestone
C++23

Comments

@Eelis
Copy link
Contributor

Eelis commented Nov 13, 2020

utilities.tex is 21K LOC. Source files this large cause some problems on github:

  • when you browse to utilities.tex, the last 4 thousand lines are silently dropped
  • when you make an issue whose description includes a reference to a line near the end of an extremely big source file, github doesn't turn it into a code citation as it normally does.
@jensmaurer
Copy link
Member

See #3388

@jensmaurer jensmaurer added this to Open in C++23 clause renumbering via automation Dec 5, 2020
@jensmaurer jensmaurer added this to the C++23 milestone Dec 5, 2020
@jensmaurer
Copy link
Member

The restructuring in #3388 has moved > 8k LOC to other files. Recent additions (e.g. std::format) have ballooned utilities.tex to 19k LOC again, but at least there's an improvement.

Closing for now.

C++23 clause renumbering automation moved this from Open to Done Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
C++23 clause renumbering
  
Done
Milestone
C++23
Development

No branches or pull requests
2 participants
@Eelis @jensmaurer