Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "could" and "might", Clauses 1-15. #4384

Merged
merged 4 commits into from Nov 25, 2020
Merged

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 19, 2020

These changes editorially remove the words "could" and "might".

Please review this change carefully with the following goals:

  • Flag anything that seems even remotely non-editorial, e.g. even if the explanation provided by a Note becomes less useful or (more) misleading.
  • Also flag anything that could conceivably be worded better by a wider review.

I would like all remaining instances of "could" and "might" to be reviewed by CWG/LWG, so please don't hold back on rejecting anything at this point.

source/basic.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated Show resolved Hide resolved
source/expressions.tex Outdated Show resolved Hide resolved
source/overloading.tex Outdated Show resolved Hide resolved
source/preprocessor.tex Outdated Show resolved Hide resolved
source/statements.tex Outdated Show resolved Hide resolved
source/templates.tex Outdated Show resolved Hide resolved
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 24, 2020

Thank you so much, @zygoloid!

@jensmaurer, @opensdh: Richard has made some great arguments here for why "can" isn't always a good choice. So we will be seeing all these reverted cases on a CWG reflector discussion, I expect; I just wanted to point out this context.

@jensmaurer
Copy link
Member

jensmaurer commented Nov 24, 2020

@tkoeppe, I actually think "might" is the perfect word to use for the possibility of risk. I'm wondering whether we should keep "might" for our working draft and just mechanically replace with "can" for ISO/CS' joys.
I'm fine with CWG reviewing specific rephrasing suggestions for accuracy, but just tossing a bunch of open-ended "might" issues over doesn't seem a good use of CWG's time.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 24, 2020

@tkoeppe, I actually think "might" is the perfect word to use for the possibility of risk. I'm wondering whether we should keep "might" for our working draft and just mechanically replace with "can" for ISO/CS' joys.
I'm fine with CWG reviewing specific rephrasing suggestions for accuracy, but just tossing a bunch of open-ended "might" issues over doesn't seem a good use of CWG's time.

Thanks, that's certainly an option -- or should I say, "we might do that"? :-)

It wouldn't be open-ended issues, though; the proposal would very specifically consist of the remaining, unmerged diffs.

@tkoeppe tkoeppe merged commit 4318184 into cplusplus:master Nov 25, 2020
@tkoeppe tkoeppe deleted the iso branch November 25, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants