Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "could" and "might", Clauses 16-32. #4386

Merged
merged 6 commits into from Nov 25, 2020
Merged

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 23, 2020

These changes editorially remove the words "could" and "might".

Please review this change carefully with the following goals:

Flag anything that seems even remotely non-editorial, e.g. even if the explanation provided by a Note becomes less useful or (more) misleading.
Also flag anything that could conceivably be worded better by a wider review.
I would like all remaining instances of "could" and "might" to be reviewed by CWG/LWG, so please don't hold back on rejecting anything at this point.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 23, 2020

@opensdh: Could you perhaps take a look at the filesystem changes?

@geoffromer: Could you perhaps take a look at the atomics and threads changes?

Thank you!

Copy link
Contributor

@opensdh opensdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filesystem changes generally look fine, but I made a few minor comments (one of which is just caught up in the same file).

source/iostreams.tex Outdated Show resolved Hide resolved
source/iostreams.tex Outdated Show resolved Hide resolved
source/iostreams.tex Outdated Show resolved Hide resolved
source/iostreams.tex Outdated Show resolved Hide resolved
Copy link
Contributor

@geoffromer geoffromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good, but I should note that I haven't been active in SG1 since February (or in editorial work for several years).

source/threads.tex Outdated Show resolved Hide resolved
source/threads.tex Outdated Show resolved Hide resolved
tkoeppe and others added 5 commits November 23, 2020 21:03
Co-authored-by: Geoff Romer <gromer@google.com>
Co-authored-by: Geoff Romer <gromer@google.com>
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 24, 2020

@CaseyCarter: could you perhaps take a look at the ranges and concepts, particularly with a view to whether "might->can" confuses risk with possibility?

@tkoeppe tkoeppe merged commit b2df325 into cplusplus:master Nov 25, 2020
@tkoeppe tkoeppe deleted the isolib branch November 25, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants