Rewordings to avoid "might" and "could" #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zygoloid, @jensmaurer, @opensdh: thoughts on this PR would be most welcome: I'd be happy to apply as much or as little of this as we agree would make an improvement. |
|
Let's not rush it for the mailing deadline. |
wg21bot
added
the
needs rebase
|
@jensmaurer, @opensdh: I'd welcome feedback on whether any of these changes sound like clearn improvements. |
tkoeppe
removed
the
needs rebase
opensdh
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rewordings were proposed by @opensdh during earlier review. They are more extensive than local replacements of "might" or "could", and we should review them on their own merit, i.e. whether they are an improvement (or at least not making things worse), and we should also consider other (possible even wider-ranging) rewordings.